[
https://issues.apache.org/jira/browse/HBASE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911956#comment-13911956
]
Nicolas Liochon commented on HBASE-10606:
-----------------------------------------
Nick, our comments crossed path.
What do you think for the setter? It's not really a 'setter bypassing
immutability', no? I can remove it for sure.
bq. This swallowed exception will now burp up in all kinds of places
(AssignmentManager, Handlers, &c), right?
There is no exception declared.
We're overcatching for sure, for example we would shallow interruption if they
were there... I can remove it as well from the patch, but I like to remove
catch throwables :-).
bq. What is "cto"? "callTimeOut"?
Yes, I will fix this.
bq. nit, ws:
Will fix as well :-)
> Bad timeout in RpcRetryingCaller#callWithRetries w/o parameters
> ---------------------------------------------------------------
>
> Key: HBASE-10606
> URL: https://issues.apache.org/jira/browse/HBASE-10606
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 10606.v1.patch, 10606.v2.patch
>
>
> When we call this method w/o parameters, we don't take into account the
> configuration, but use the hardcoded default (Integer.MAX).
> If someone was relying on having an infinite timeout whatever the setting,
> fixing this bug will cause him a surprise. But there is no magic...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
