[ https://issues.apache.org/jira/browse/HBASE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912557#comment-13912557 ]
Hadoop QA commented on HBASE-10592: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631126/HBASE-10592.01.patch against trunk revision . ATTACHMENT ID: 12631126 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8809//console This message is automatically generated. > Refactor PerformanceEvaluation tool > ----------------------------------- > > Key: HBASE-10592 > URL: https://issues.apache.org/jira/browse/HBASE-10592 > Project: HBase > Issue Type: Improvement > Components: test > Affects Versions: 0.96.2, 0.98.1, 0.99.0 > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10592.00-0.96.patch, HBASE-10592.00-0.98.patch, > HBASE-10592.00.patch, HBASE-10592.01-0.96.patch, HBASE-10592.01-0.98.patch, > HBASE-10592.01.patch > > > PerfEval is kind of a mess. It's painful to add new features because the test > options are itemized and passed as parameters to internal methods. > Serialization is hand-rolled and tedious. Ensuring support for mapreduce mode > is a chore because of it. > This patch refactors the tool. Options are now passed around to methods and > such as a POJO instead of one-by-one. Get rid of accessors that don't help > anyone. On the mapreduce side, serialization is now handled using json > (jackson is a dependency anyway) instead of the hand-rolled regex we used > before. Also do away with custom InputSplit and FileFormat, instead using > Text and NLineInputFormat. On the local mode side, combine 1 client and N > clients into the same implementation. That implementation now uses an > ExecutorService, so we can later decouple number of client workers from > number of client tasks. Finally, drop a bunch of confusing local state, > instead use the new TestOptions POJO as a parameter to static methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160)