[ https://issues.apache.org/jira/browse/HBASE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914669#comment-13914669 ]
Hadoop QA commented on HBASE-8304: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631523/HBASE-8304-v2.patch against trunk revision . ATTACHMENT ID: 12631523 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + public static Set<InetSocketAddress> getNNAddresses(DistributedFileSystem fs, Configuration conf) throws IOException { + getNNAddressesMethod = dfsUtilClazz.getMethod("getNNServiceRpcAddresses", Configuration.class); + (Map<String, Map<String, InetSocketAddress>>) getNNAddressesMethod.invoke(null, conf); + public static boolean isSameHdfs(Configuration conf, FileSystem srcFs, FileSystem desFs) throws IOException { + // By getCanonicalServiceName, we could make sure both srcFs and desFs show an unified format which contains scheme, host and port. + //If one serviceName is a HA format while the other is a no-HA format, maybe they are refer to the same FileSystem. {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8836//console This message is automatically generated. > Bulkload fail to remove files if fs.default.name / fs.defaultFS is configured > without default port. > --------------------------------------------------------------------------------------------------- > > Key: HBASE-8304 > URL: https://issues.apache.org/jira/browse/HBASE-8304 > Project: HBase > Issue Type: Bug > Components: HFile, regionserver > Affects Versions: 0.94.5 > Reporter: Raymond Liu > Labels: bulkloader > Attachments: HBASE-8304-v2.patch, HBASE-8304.patch > > > When fs.default.name or fs.defaultFS in hadoop core-site.xml is configured as > hdfs://ip, and hbase.rootdir is configured as hdfs://ip:port/hbaserootdir > where port is the hdfs namenode's default port. the bulkload operation will > not remove the file in bulk output dir. Store::bulkLoadHfile will think > hdfs:://ip and hdfs:://ip:port as different filesystem and go with copy > approaching instead of rename. > The root cause is that hbase master will rewrite fs.default.name/fs.defaultFS > according to hbase.rootdir when regionserver started, thus, dest fs uri from > the hregion will not matching src fs uri passed from client. > any suggestion what is the best approaching to fix this issue? > I kind of think that we could check for default port if src uri come without > port info. -- This message was sent by Atlassian JIRA (v6.1.5#6160)