[ 
https://issues.apache.org/jira/browse/HBASE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915076#comment-13915076
 ] 

Ted Yu commented on HBASE-10576:
--------------------------------

Please fix the 2 new findbugs warnings - HBASE-10624 covers the other two.
{code}
+  private static final Random RANDOM = new Random(System.currentTimeMillis());
{code}
Use EnvironmentEdge above.
{code}
+      Map<ImmutableBytesWritable, ServerName> tabkeKeys = 
this.colocationInfo.get(tableName);
{code}
We should move away from Writables, right ?

In getServerNameFromMap():
{code}
+    TableName mappedTable = getMappedTableToColocate(regionInfo.getTable());
{code}
What if mappedTable is the same as tableName ?

> Custom load balancer to co-locate the regions of two tables which are having 
> same split keys
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10576
>                 URL: https://issues.apache.org/jira/browse/HBASE-10576
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Balancer
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: HBASE-10576.patch
>
>
> To support local indexing both user table and index table should have same 
> split keys. This issue to provide custom balancer to colocate the regions of 
> two tables which are having same split keys. 
> This helps in Phoenix as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to