[
https://issues.apache.org/jira/browse/HBASE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070349#comment-13070349
]
dhruba borthakur commented on HBASE-4132:
-----------------------------------------
stack: the LogCleaner api allows archived logs to be deleted according to a
configurable policy. One can set hbase.master.logcleaner.plugins to setup his
own policy. In that sense, it is already pluggable. Moreover, this is done by
the master whereas the WALObserver interface is in the RegionServer. Given the
above, do you think that this patch needs to touch LogCleaner at all? If so,
what is ur proposal?
Andrew: "The WALObserver API additions should follow the same practice as
providing before (pre) and after (post) hooks as everywhere else". In that
sense, it already has logRollRequested and logRolled. Similarly, I added
logArchiveStart and logArchiveCompleted. The remaining one is
"visitLogEntryBeforeWrite". are you suggesting that we add a
"visitLogEntryAfterWrite" as well?
> Extend the WALObserver API to accomodate log archival
> -----------------------------------------------------
>
> Key: HBASE-4132
> URL: https://issues.apache.org/jira/browse/HBASE-4132
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.92.0
>
> Attachments: walArchive.txt
>
>
> The WALObserver interface exposes the log roll events. It would be nice to
> extend it to accomodate log archival events as well.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
