[ 
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923548#comment-13923548
 ] 

Lars Hofhansl commented on HBASE-10531:
---------------------------------------

bq. code with copy performs faster.

That's unexpected. These both generate Get requests, right?

I was looking at this code again. In SQM.getKeyForNextColumn and 
SQL.getKeyForNextRow make a brandnew KV (copy of key, FQ, CQ) just to pass down 
a search key.
If we already create one of your derived KVs there we'd save yet another copy.


> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10531
>                 URL: https://issues.apache.org/jira/browse/HBASE-10531
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10531.patch, HBASE-10531_1.patch, 
> HBASE-10531_2.patch
>
>
> Currently the byte[] key passed to HFileScanner.seekTo and 
> HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts.  And 
> the caller forms this by using kv.getBuffer, which is actually deprecated.  
> So see how this can be achieved considering kv.getBuffer is removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to