[ https://issues.apache.org/jira/browse/HBASE-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938210#comment-13938210 ]
Hudson commented on HBASE-10766: -------------------------------- SUCCESS: Integrated in HBase-0.98 #239 (See [https://builds.apache.org/job/HBase-0.98/239/]) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578451) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java > SnapshotCleaner allows to delete referenced files > ------------------------------------------------- > > Key: HBASE-10766 > URL: https://issues.apache.org/jira/browse/HBASE-10766 > Project: HBase > Issue Type: Bug > Components: snapshots > Affects Versions: 0.98.0, 0.96.1.1, 0.94.17 > Reporter: Matteo Bertozzi > Assignee: bharath v > Fix For: 0.96.2, 0.99.0, 0.94.18, 0.98.2 > > Attachments: HBASE-10766-v1.patch, HBASE-10766-v2.patch > > > The SnapshotFileCache is checking the lastModificationTime() of the > ".hbase-snapshot" directory. > But in this way "pending" snapshots created in temp are not considered. > since only the parent directory timestamp is updated. > so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification > timestamp of .hbase-snapshot will not be updated > https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197 -- This message was sent by Atlassian JIRA (v6.2#6252)