[ 
https://issues.apache.org/jira/browse/HBASE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939439#comment-13939439
 ] 

Lars Hofhansl commented on HBASE-10648:
---------------------------------------

Looks good in principle. Doesn't change the behavior by default, so I have no 
problem with this.
Nit: There are some references to Cells in some of the comments. Cells do not 
exist in 0.94 so we should change this.

Two issues:
# For this to be 0.94 it has to be in 0.96 and 0.98 as well. So [~stack] and 
[~apurtell] would have to agree as well.
# I wonder if that breaks some users of coprocessors. [~giacomotaylor], mind 
having a quick lock to see if that break anything for Phoenix? I don't think 
unless Phoenix manually allocates a memstore, but should check.


> Pluggable Memstore
> ------------------
>
>                 Key: HBASE-10648
>                 URL: https://issues.apache.org/jira/browse/HBASE-10648
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10648-0.94_v1.patch, HBASE-10648-0.94_v2.patch, 
> HBASE-10648.patch, HBASE-10648_V2.patch, HBASE-10648_V3.patch, 
> HBASE-10648_V4.patch, HBASE-10648_V5.patch, HBASE-10648_V6.patch
>
>
> Make Memstore into an interface implementation.  Also make it pluggable by 
> configuring the FQCN of the impl.
> This will allow us to have different impl and optimizations in the Memstore 
> DataStructure and the upper layers untouched.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to