[ https://issues.apache.org/jira/browse/HBASE-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946198#comment-13946198 ]
stack commented on HBASE-7847: ------------------------------ This comment seems out of place but we can fix on commit: + // Delete the leaves first and eventually get rid of the root Should this be true by default? + deleteChildrenRecursivelyMultiOrSequential(zkw, false, node); i.e. retry with the sequential if the multi fails? What is happening here? + List<Op> opList = new ArrayList<Op>(); + List<ZKUtilOp> ops = new ArrayList<ZKUtil.ZKUtilOp>(opList.size()); The opList has zero size. Is that what you want? Call out BFS for what it is. Nice tests. > Use zookeeper multi to clear znodes > ----------------------------------- > > Key: HBASE-7847 > URL: https://issues.apache.org/jira/browse/HBASE-7847 > Project: HBase > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Rakesh R > Attachments: 7847-v1.txt, 7847_v6.patch, 7847_v6.patch, > HBASE-7847.patch, HBASE-7847.patch, HBASE-7847.patch, HBASE-7847_v4.patch, > HBASE-7847_v5.patch, HBASE-7847_v6.patch > > > In ZKProcedureUtil, clearChildZNodes() and clearZNodes(String procedureName) > should utilize zookeeper multi so that they're atomic -- This message was sent by Atlassian JIRA (v6.2#6252)