[ https://issues.apache.org/jira/browse/HBASE-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947407#comment-13947407 ]
Hadoop QA commented on HBASE-10829: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636804/hbase-10829_v3.patch against trunk revision . ATTACHMENT ID: 12636804 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9094//console This message is automatically generated. > Flush is skipped after log replay if the last recovered edits file is skipped > ----------------------------------------------------------------------------- > > Key: HBASE-10829 > URL: https://issues.apache.org/jira/browse/HBASE-10829 > Project: HBase > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Priority: Critical > Fix For: 0.99.0, 0.98.2, 0.96.3 > > Attachments: hbase-10829_v1.patch, hbase-10829_v2.patch, > hbase-10829_v3.patch > > > We caught this in an extended test run where IntegrationTestBigLinkedList > failed with some missing keys. > The problem is that HRegion.replayRecoveredEdits() would return -1 if all the > edits in the log file is skipped, which is true for example if the log file > only contains a single compaction record (HBASE-2231) or somehow the edits > cannot be applied (column family deleted, etc). > The callee, HRegion.replayRecoveredEditsIfAny() only looks for the last > returned seqId to decide whether a flush is necessary or not before opening > the region, and discarding replayed recovered edits files. > Therefore, if the last recovered edits file is skipped but some edits from > earlier recovered edits files are applied, the mandatory flush before opening > the region is skipped. If the region server dies after this point before a > flush, the edits are lost. > This is important to fix, though the sequence of events are super rare for a > production cluster. -- This message was sent by Atlassian JIRA (v6.2#6252)