[ https://issues.apache.org/jira/browse/HBASE-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948435#comment-13948435 ]
Ted Yu commented on HBASE-10842: -------------------------------- lgtm > Some logger not declared static final > ------------------------------------- > > Key: HBASE-10842 > URL: https://issues.apache.org/jira/browse/HBASE-10842 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.98.1, 0.96.1.1 > Reporter: Richard Ding > Assignee: Richard Ding > Priority: Minor > Attachments: HBASE-10842.patch, HBASE-10842.patch > > > In a few of source files, the logger is defined as > {code} > private final Log LOG = LogFactory.getLog(MyClass.class); > {code} > This should be changed to static final. > One question is about the following declaration: > {code} > private final Log LOG = LogFactory.getLog(this.getClass()); > {code} > In this form, the logger can be shared by derived classes. But one will get > NPE when logging in methods that are invoked inside the constructors. -- This message was sent by Atlassian JIRA (v6.2#6252)