[ https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073113#comment-13073113 ]
jirapos...@reviews.apache.org commented on HBASE-4027: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1214/#review1238 ----------------------------------------------------------- conf/hbase-env.sh <https://reviews.apache.org/r/1214/#comment2812> Still some whitespaces. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java <https://reviews.apache.org/r/1214/#comment2813> Doesn't match actual name of class. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java <https://reviews.apache.org/r/1214/#comment2814> I don't see SkipList being used in this class. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java <https://reviews.apache.org/r/1214/#comment2815> This doesn't match the actual test. - Ted On 2011-07-30 00:39:48, Li Pi wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1214/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-30 00:39:48) bq. bq. bq. Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, Jonathan Gray, and Li Pi. bq. bq. bq. Summary bq. ------- bq. bq. Review request - I apparently can't edit tlipcon's earlier posting of my diff, so creating a new one. bq. bq. bq. This addresses bug HBase-4027. bq. https://issues.apache.org/jira/browse/HBase-4027 bq. bq. bq. Diffs bq. ----- bq. bq. conf/hbase-env.sh 2d55d27 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 509121d bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheTestUtils.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java ecab7ca bq. src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 150f54f bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1d5e3fa bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java b600020 bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSlabCache.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlab.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/1214/diff bq. bq. bq. Testing bq. ------- bq. bq. Ran benchmarks against it in HBase standalone mode. Wrote test cases for all classes, multithreaded test cases exist for the cache. bq. bq. bq. Thanks, bq. bq. Li bq. bq. > Enable direct byte buffers LruBlockCache > ---------------------------------------- > > Key: HBASE-4027 > URL: https://issues.apache.org/jira/browse/HBASE-4027 > Project: HBase > Issue Type: Improvement > Reporter: Jason Rutherglen > Assignee: Li Pi > Priority: Minor > Attachments: 4027-v5.diff, 4027v7.diff, HBase-4027 (1).pdf, > HBase-4027.pdf, hbase-4027v6.diff, slabcachepatch.diff, > slabcachepatchv2.diff, slabcachepatchv3.1.diff, slabcachepatchv3.2.diff, > slabcachepatchv3.diff, slabcachepatchv4.5.diff, slabcachepatchv4.diff > > > Java offers the creation of direct byte buffers which are allocated outside > of the heap. > They need to be manually free'd, which can be accomplished using an > documented {{clean}} method. > The feature will be optional. After implementing, we can benchmark for > differences in speed and garbage collection observances. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira