[ 
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956094#comment-13956094
 ] 

stack commented on HBASE-10867:
-------------------------------

Hmm... Looks like Ted already committed.  This is what I'd remove:

{code}
Index: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
===================================================================
--- 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
  (revision 1583526)
+++ 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
  (working copy)
@@ -289,8 +289,6 @@

   private void killRandomServerAndVerifyAssignment()
       throws IOException, InterruptedException, KeeperException {
-    ClusterStatus oldStatus = TEST_UTIL.getHBaseCluster().getClusterStatus();
-    ServerName servers[] = oldStatus.getServers().toArray(new ServerName[10]);
     ServerName serverToKill = null;
     int killIndex = 0;
     Random random = new Random(System.currentTimeMillis());
{code}

... but this test does not behave well for me locally.  I am afraid to touch it.

> TestRegionPlacement#testRegionPlacement occasionally fails
> ----------------------------------------------------------
>
>                 Key: HBASE-10867
>                 URL: https://issues.apache.org/jira/browse/HBASE-10867
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From 
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
>  :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
>       at 
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
>       at 
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
>       at 
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
>       at 
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
>       at 
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
>       at 
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
>     TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in 
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get 
> ArrayIndexOutOfBoundsException.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to