[ 
https://issues.apache.org/jira/browse/HBASE-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958803#comment-13958803
 ] 

Hadoop QA commented on HBASE-10883:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12638458/HBASE-10883_3.patch
  against trunk revision .
  ATTACHMENT ID: 12638458

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels
                  org.apache.hadoop.hbase.rest.TestScannersWithLabels
                  
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
                  
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
                  
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
                  
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9191//console

This message is automatically generated.

> Restrict the universe of labels and authorizations
> --------------------------------------------------
>
>                 Key: HBASE-10883
>                 URL: https://issues.apache.org/jira/browse/HBASE-10883
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.1
>            Reporter: Andrew Purtell
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-10883.patch, HBASE-10883_1.patch, 
> HBASE-10883_2.patch, HBASE-10883_3.patch
>
>
> Currently we allow any string as visibility label or request authorization. 
> However as seen on HBASE-10878, we accept for authorizations strings that 
> would not work if provided as labels in visibility expressions. We should 
> throw an exception at least in cases where someone tries to define or use a 
> label or authorization including visibility expression operators '&', '|', 
> '!', '(', ')'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to