[
https://issues.apache.org/jira/browse/HBASE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073814#comment-13073814
]
Mikhail Bautin commented on HBASE-3857:
---------------------------------------
The new version of the patch is successfully passing the randomized load test
as well.
I am trying to compare unit test results between r1152122 and the same version
with the patch applied.
Without the patch:
2011-08-01_10_55_23 commit: HBASE-4144 RS does not abort if th | tests: 812,
fail: 4, err: 14, skip: 9, time: 4791.1, failed: FullLogReconstruction,
DistributedLogSplitting, SplitTransactionOnCluster, ScannerTimeout,
MasterFailover, MultiParallel
With the patch:
2011-08-01_11_34_28 commit: review_hfile-v2-r1152122-2011_08_01 | tests: 845,
fail: 5, err: 14, skip: 9, time: 5426.5, failed: FullLogReconstruction,
DistributedLogSplitting, ServerCustomProtocol, Replication,
SplitTransactionOnCluster, ScannerTimeout, MasterFailover, MultiParallel
Looking at the ServerCustomProtocol (the only test that has failures with the
patch but not without), I see that this is a quite frequent intermittent test
failure in my automated runs of HBase trunk tests.
Any advice about what version I should select as the baseline for my unit test
run? The only trunk version that I managed to get a clean unit test run with
was r1147350, and my patch against that passed all unit tests as well, but I
think some changes were introduced since then that made the patch not apply
cleanly, so I rebased the patch to a more recent version (and got all the test
failures of that version).
Notwithstanding all the above, I believe the patch is currently in a stable
state and can be committed, and I will confirm that once a few more unit test
runs complete.
> Change the HFile Format
> -----------------------
>
> Key: HBASE-3857
> URL: https://issues.apache.org/jira/browse/HBASE-3857
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 0.90.4
> Reporter: Liyin Tang
> Assignee: Mikhail Bautin
> Attachments: 0001-review_hfile-v2-r1144693_2011-07-15_11_14_44.patch,
> 0001-review_hfile-v2-r1147350_2011-07-26_11_55_59.patch,
> 0001-review_hfile-v2-r1152122-2011_08_01_03_18_00.patch,
> hfile_format_v2_design_draft_0.1.pdf, hfile_format_v2_design_draft_0.3.pdf,
> hfile_format_v2_design_draft_0.4.odt
>
>
> In order to support HBASE-3763 and HBASE-3856, we need to change the format
> of the HFile. The new format proposal is attached here. Thanks for Mikhail
> Bautin for the documentation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
