[
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961337#comment-13961337
]
Ted Yu commented on HBASE-8963:
-------------------------------
Please keep line length at 100 or shorter.
{code}
+ setValue(SKIP_ARCHIVE_KEY,skip?TRUE:FALSE);
{code}
nit: insert space following comma, around question mark and colon.
{code}
+ FileStatus currentStatus = fs.getFileStatus(currentFile.getPath());
+
+ if(conf.getBoolean(HFILE_SKIP_ARCHIVE_CONF_KEY, true) || ((htd != null) &&
htd.isSkipArchiveEnabled())){
{code}
currentStatus is only used within the if block - you can move it inside the if
block.
{code}
+ if(fs.delete(currentFile.getPath())){
{code}
Please insert space between if and '(' - applies to other if statements in
patch.
{code}
+ final HTable t = new HTable(UTIL.getConfiguration(), TEST_TABLE);
{code}
Where is t closed ?
> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
> Key: HBASE-8963
> URL: https://issues.apache.org/jira/browse/HBASE-8963
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: bharath v
> Fix For: 0.99.0
>
> Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch,
> HBASE-8963.trunk.v3.patch, HBASE-8963.trunk.v4.patch,
> HBASE-8963.trunk.v5.patch, HBASE-8963.trunk.v6.patch,
> HBASE-8963.trunk.v7.patch, HBASE-8963.trunk.v8.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so
> that archiving can be skipped when table is deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
