[ 
https://issues.apache.org/jira/browse/HBASE-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961952#comment-13961952
 ] 

Nicolas Liochon commented on HBASE-10701:
-----------------------------------------

I reviewed v4
I'm +1, just a nit that can be fixed on commit:

{code}
          Future<Result> f = cs.take();
          if (f != null) {
            return f.get(); // great we got an answer
          }
{code}
In the secondaries part, I don't think that cs.take can return null.

> Cache invalidation improvements from client side
> ------------------------------------------------
>
>                 Key: HBASE-10701
>                 URL: https://issues.apache.org/jira/browse/HBASE-10701
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: hbase-10070
>
>         Attachments: hbase-10701_v1.patch, hbase-10701_v1.patch, 
> hbase-10701_v2.patch, hbase-10701_v3.patch, hbase-10701_v4.patch
>
>
> Running the integration test in HBASE-10572, and HBASE-10355, it seems that 
> we need some changes for cache invalidation of meta entries from the client 
> side in backup RPCs. 
> Mainly the RPC's made for replicas should not invalidate the cache for all 
> the replicas (for example on RegionMovedException, connection error etc). 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to