[ 
https://issues.apache.org/jira/browse/HBASE-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963957#comment-13963957
 ] 

Anoop Sam John commented on HBASE-7319:
---------------------------------------

Oh.. It is a big patch..Just started going through it Ram.  One quick comment
{code}
       KeyValue kv = KeyValueUtil.ensureKeyValue(kvs[i]);
-      if (kv.matchingColumn(family,qualifier)) {
+      if (CellUtil.matchingColumn(kv, family,qualifier)) {
{code}
Now when u use CellUtil why still need KeyValueUtil.ensureKeyValue(kvs[i])?   
This is there in some places.

> Extend Cell usage through read path
> -----------------------------------
>
>                 Key: HBASE-7319
>                 URL: https://issues.apache.org/jira/browse/HBASE-7319
>             Project: HBase
>          Issue Type: Umbrella
>          Components: Compaction, Performance, regionserver, Scanners
>            Reporter: Matt Corgan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-7319.patch, HBASE-7319_1.patch, HBASE-7319_1.patch
>
>
> Umbrella issue for eliminating Cell copying.
> The Cell interface allows us to work with a reference to underlying bytes in 
> the block cache without copying each Cell into consecutive bytes in an array 
> (KeyValue).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to