[ 
https://issues.apache.org/jira/browse/HBASE-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965070#comment-13965070
 ] 

Matt Corgan commented on HBASE-10861:
-------------------------------------

{quote}In HBASE-10771 we had some discussion regarding that. Matt Corgan mind 
taking a look at the patch on that Jira.{quote}sure, i left some comments over 
there.

{quote}So do we have a consensus regarding the BR backed by offheap ?{quote}i 
hate advocate too strongly for it since there are so many unknowns, but I do 
think we need some sort of wrapper object for byte[]'s and ByteBuffers.  i just 
think it strange that java doesn't include a wrapper for byte[]'s like String 
wraps char[].  The biggest difference from String is that we're talking about a 
mutable wrapper, but I think we could get a lot of mileage out of recycling the 
ByteRange wrapper in performance critical spots - just need to be careful.

> Supporting API in ByteRange
> ---------------------------
>
>                 Key: HBASE-10861
>                 URL: https://issues.apache.org/jira/browse/HBASE-10861
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-10861.patch, HBASE-10861_2.patch
>
>
> We would need APIs that would 
> setLimit(int limit)
> getLimt()
> asReadOnly()
> These APIs would help in implementations that have Buffers offheap (for now 
> BRs backed by DBB).
> If anything more is needed could be added when needed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to