[ https://issues.apache.org/jira/browse/HBASE-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974386#comment-13974386 ]
stack commented on HBASE-11030: ------------------------------- +1 > HBaseTestingUtility.getMiniHBaseCluster should be able to return null > --------------------------------------------------------------------- > > Key: HBASE-11030 > URL: https://issues.apache.org/jira/browse/HBASE-11030 > Project: HBase > Issue Type: Bug > Reporter: Lars Hofhansl > Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3 > > Attachments: 11030-trunk.txt > > > Right now we have this logic: > {code} > public MiniHBaseCluster getMiniHBaseCluster() { > if (this.hbaseCluster instanceof MiniHBaseCluster) { > return (MiniHBaseCluster)this.hbaseCluster; > } > throw new RuntimeException(hbaseCluster + " not an instance of " + > MiniHBaseCluster.class.getName()); > } > {code} > Since null is not actually an instance of MiniHBaseCluster we'll throw the > RuntimeException rather than returning null. > Some tests call this method and check for null, which is pointless. -- This message was sent by Atlassian JIRA (v6.2#6252)