[
https://issues.apache.org/jira/browse/HBASE-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080469#comment-13080469
]
stack commented on HBASE-4169:
------------------------------
@Lohit Patch is not bad. You did it this way because the bulk of FSUtils is
static so not subclassable? The naming is a little awkward I'd say.
FSImplementedUtils is a little odd when we still have FSUtils (And
FSImplementedUtils is a factory so why not call it so?). I'd imagine going
forward there'll be more than just this one method different across fs
implementations? Do you think this method even belongs in our util package? I
know thats where it was before you went messing but it seems more fundamental
than a utility. Perhaps we need an fs package and in there you'd have an fs
factory class that provides different fs implementations for different methods?
You are trying to avoid doing 'mapr://' for the fs? (Even if you did mapr://
you'd need to change how we do this recoverLease). Good stuff.
> FSUtils LeaseRecovery for non HDFS FileSystems.
> -----------------------------------------------
>
> Key: HBASE-4169
> URL: https://issues.apache.org/jira/browse/HBASE-4169
> Project: HBase
> Issue Type: Bug
> Components: util
> Affects Versions: 0.90.3, 0.90.4
> Reporter: Lohit Vijayarenu
> Attachments: HBASE-4169.1.patch
>
>
> FSUtils.recoverFileLease uses HDFS's recoverLease method to get lease before
> splitting hlog file.
> This might not work for other filesystem implementations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
