[ 
https://issues.apache.org/jira/browse/HBASE-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982066#comment-13982066
 ] 

Jerry He commented on HBASE-11061:
----------------------------------

Hi, [~stack]
Here is the method in org.apache.hadoop.fs.permission in hadoop 2:
  /**
   * Get the default permission for file.
   */
  public static FsPermission getFileDefault() {
    return new FsPermission((short)00666);
  }

This method is not in hadoop 1.
I put the same name with the same implementation in our HBase FSUtils for 
0.96/0.98 so that 0.96/0.98 can use this implementation, even on hadoop 1.
In a sense e are actually always using hadoop 2 implementation. 
Of course there is a risk with this hard-code approach, if the implementation 
evolves in hadoop 2.  But it is a very small risk that we can live with in 
0.96/0.98

To use the hadoop-compat modules, I think I will need to do these:
1.  Have a wrapper interface in hadoop-compact.
2.  In hadoop2-compact,  the wrapper will directly call 
org.apache.hadoop.fs.permission#getFileDefault().
3.  In hadoop1-compact, the wrapper will call an internal method that has the 
same implementation as org.apache.hadoop.fs.permission#getFileDefault()
Probably an over-kill?

> Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
> -------------------------------------------------------------
>
>                 Key: HBASE-11061
>                 URL: https://issues.apache.org/jira/browse/HBASE-11061
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jerry He
>         Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch
>
>
> HBASE-10948 fixed the issue where hbase table files all have 'x' mode.
> This JIRA is to port the fix to 0.96 / 0.98 branches.
> The port doesn't rely on API specific to hadoop 2.0



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to