[
https://issues.apache.org/jira/browse/HBASE-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992513#comment-13992513
]
Hadoop QA commented on HBASE-11108:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12643881/HBASE-11108.patch
against trunk revision .
ATTACHMENT ID: 12643881
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 112
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ boolean disabled =
getTableStateManager().isDisablingOrDisabledTable(regionInfo.getTable());
+ if (!tableStateManager.isEnablingTable(tableName) &&
!tableStateManager.isEnabledTable(tableName)) {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.TestDrainingServer
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
{color:red}-1 core zombie tests{color}. There are 3 zombie test(s):
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsThatDoesNotPassTheCriteria(TestVisibilityLabels.java:195)
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testSplitHooksBeforeAndAfterPONR(TestSplitTransactionOnCluster.java:995)
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testMasterRestartWhenSplittingIsPartial(TestSplitTransactionOnCluster.java:678)
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShouldFailSplitIfZNodeDoesNotExistDueToPrevRollBack(TestSplitTransactionOnCluster.java:177)
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testTableExistsIfTheSpecifiedTableRegionIsSplitParent(TestSplitTransactionOnCluster.java:848)
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testRITStateForRollback(TestSplitTransactionOnCluster.java:260)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsThatDoesNotPassTheCriteria(TestVisibilityLabels.java:195)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9480//console
This message is automatically generated.
> Split ZKTable into interface and implementation
> -----------------------------------------------
>
> Key: HBASE-11108
> URL: https://issues.apache.org/jira/browse/HBASE-11108
> Project: HBase
> Issue Type: Sub-task
> Components: Consensus, Zookeeper
> Affects Versions: 0.99.0
> Reporter: Konstantin Boudnik
> Assignee: Mikhail Antonov
> Attachments: HBASE-11108.patch
>
>
> In HBASE-11071 we are trying to split admin handlers away from ZK. However, a
> ZKTable instance is being used in multiple places, hence it would be
> beneficial to hide its implementation behind a well defined interface.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
