[ 
https://issues.apache.org/jira/browse/HBASE-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997449#comment-13997449
 ] 

Nicolas Liochon commented on HBASE-11098:
-----------------------------------------

This does more than just improving the doc :-)
{noformat}
===================================================================
--- 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
        (revision 1594409)
+++ 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
        (working copy)
@@ -53,6 +53,8 @@
           + StringUtils.byteDesc(fileSize), ioex);
       if (raf != null) raf.close(); 
       throw ioex;
+    } finally {
+      if (raf != null) raf.close(); <== hum, no :-)
     }
   }
{noformat}

It breaks the TestFileIOEngine
The addendum proposes a fix.




> Improve documentation around our blockcache options
> ---------------------------------------------------
>
>                 Key: HBASE-11098
>                 URL: https://issues.apache.org/jira/browse/HBASE-11098
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0
>
>         Attachments: 11098.txt, 11098v2.txt, 11098v3.txt
>
>
> Adding as a subtask on [~ndimiduk] necessary cleanup.  Trying to make sense 
> of this stuff I started adding doc (package-info files, javadoc).  I see this 
> as complementary to the parent task work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to