[
https://issues.apache.org/jira/browse/HBASE-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000134#comment-14000134
]
stack commented on HBASE-11186:
-------------------------------
Took a quick look. LGTM. I applied the patch to trunk locally and the
refactored test failed with this:
{code}
Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 303.551 sec <<<
FAILURE!
testSnapshotWithRefsExportFileSystemState(org.apache.hadoop.hbase.snapshot.TestExportSnapshot)
Time elapsed: 23.841 sec <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:288)
at
org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:260)
at
org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:254)
at
org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testSnapshotWithRefsExportFileSystemState(TestExportSnapshot.java:234)
...
{code}
Did I do something wrong?
> Improve TestExportSnapshot verifications
> ----------------------------------------
>
> Key: HBASE-11186
> URL: https://issues.apache.org/jira/browse/HBASE-11186
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 0.99.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-11186-v0.patch
>
>
> * Remove some code by using the utils that we already have in
> SnapshotTestingUtil
> * Add an Export with references for both v1 and v2 format
> * add the verification on the actual number of files exported
--
This message was sent by Atlassian JIRA
(v6.2#6252)
