[ 
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008311#comment-14008311
 ] 

Qiang Tian commented on HBASE-11096:
------------------------------------

Hi [~apurtell],
it looks the shutdown method is not called..could you please check if the patch 
apply to the MasterCoprocessorHost.java correctly? I just run command "patch 
-p0< ../backup/HBASE-11096-trunk-v3.patch" to trunk, and the change is not 
applied correctly.     

ps when I firstly saw your update on 20/5, I merged the code with latest code 
using "git merge" command and the test running fine. 
today I used "git rebase" command to merge my local branch with the latest code 
(since you recommended rebase in mailing list), and I got the error ---after 
investigation the MasterCoprocessorHost.java was not merged correctly..  

I did a search, it looks git rebase uses patch command to do the final merge. 
so if patch does not work correctly, the rebase will fail too...

pps..this is my second time to see patch command fails...Did I use wrong option?




> stop method of Master and RegionServer coprocessor  is not invoked
> ------------------------------------------------------------------
>
>                 Key: HBASE-11096
>                 URL: https://issues.apache.org/jira/browse/HBASE-11096
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.2, 0.98.1, 0.94.19
>            Reporter: Qiang Tian
>            Assignee: Qiang Tian
>             Fix For: 0.99.0, 0.96.3, 0.94.21, 0.98.4
>
>         Attachments: HBASE-11096-0.94.patch, HBASE-11096-0.96.patch, 
> HBASE-11096-0.98.patch, HBASE-11096-trunk-v0.patch, 
> HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v1.patch, 
> HBASE-11096-trunk-v2.patch, HBASE-11096-trunk-v3.patch, 
> HBASE-11096-trunk-v3.patch, TestCoprocessorStop-failed-output.txt
>
>
> the stop method of coprocessor specified by 
> "hbase.coprocessor.master.classes" and  
> "hbase.coprocessor.regionserver.classes"  is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver 
> resource leak or hang during exit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to