[ https://issues.apache.org/jira/browse/HBASE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082717#comment-13082717 ]
jirapos...@reviews.apache.org commented on HBASE-3810: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1051/#review1394 ----------------------------------------------------------- Just the one comment which I think needs fixing before we commit else patch is looking good. src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java <https://reviews.apache.org/r/1051/#comment3186> This is a bit odd where a class in the parent package has references to a sub package. Should these classes or at least their constants be pulled up to be at same level as HTableD? - Michael On 2011-08-02 17:29:06, Mingjie Lai wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1051/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-02 17:29:06) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Registering a Coprocessor at HTableDescriptor should be less strict bq. - fix regex to account for whitespace around ":" separators bq. - make path portion optional – we already skip the path handling if the class can be loaded by the classloader bq. - make priority optional and default to "USER" bq. bq. At revision 3, added HTableDecriptor.addCoprocessor() for loading a table level coprocessor. bq. bq. bq. This addresses bug HBase-3810. bq. https://issues.apache.org/jira/browse/HBase-3810 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 0641f52 bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java c2b3558 bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java e0bde92 bq. bq. Diff: https://reviews.apache.org/r/1051/diff bq. bq. bq. Testing bq. ------- bq. bq. Tests passed locally. bq. bq. bq. Thanks, bq. bq. Mingjie bq. bq. > Registering a Coprocessor at HTableDescriptor should be less strict > ------------------------------------------------------------------- > > Key: HBASE-3810 > URL: https://issues.apache.org/jira/browse/HBASE-3810 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Affects Versions: 0.92.0 > Environment: all > Reporter: Joerg Schad > Assignee: Mingjie Lai > Priority: Minor > Fix For: 0.92.0 > > Attachments: HBASE-3810_final.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > Registering a Copressor in the following way will fail as the "Coprocessor$1" > keyword is case sensitive (instead COPROCESSOR$1 works fine). Removing this > restriction would improve usability. > HTableDescriptor desc = new HTableDescriptor(tName); > desc.setValue("Coprocessor$1", > path.toString() + ":" + full_class_name + > ":" + Coprocessor.Priority.USER); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira