[ 
https://issues.apache.org/jira/browse/HBASE-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033179#comment-14033179
 ] 

Hadoop QA commented on HBASE-11364:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12650658/11364.txt
  against trunk revision .
  ATTACHMENT ID: 12650658

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +   * <code>hbase(main):003:0> create 't', {NAME => 't', CONFIGURATION => 
{CACHE_DATA_IN_L1 => 'true'}}</code>
+          LruBlockCache, and BucketCache, and SlabCache, which are both 
(usually) offheap. This section
+              two tiers and how blocks move between them is done by 
<classname>DoubleBlockCache</classname>
+              <xref linkend="offheap.blockcache.slabcache" /> for more detail 
on how DoubleBlockCache works.
+              It keeps all DATA blocks in the BucketCache and meta blocks -- 
INDEX and BLOOM blocks --
+              works so differently, it is difficult to do a fair comparison 
between BucketCache and SlabCache.
+                
xlink:href="http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/io/hfile/CacheConfig.html";
 />.
+                
<programlisting>HColumnDescriptor.setInMemory(true);</programlisting> if 
creating a table from java,
+                the shell: e.g.  <programlisting>hbase(main):003:0> create  
't', {NAME => 'f', IN_MEMORY => 'true'}</programlisting></para>
+              DoubleBlockCache is an abstraction layer that combines two 
caches, the smaller onHeapCache and the

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9779//console

This message is automatically generated.

> [BlockCache] Add a flag to cache data blocks in L1 if multi-tier cache
> ----------------------------------------------------------------------
>
>                 Key: HBASE-11364
>                 URL: https://issues.apache.org/jira/browse/HBASE-11364
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 11364.txt
>
>
> This is a prerequisite for HBASE-11323 BucketCache on all the time.  It 
> addresses a @lars hofhansl ask that we be able to ask that for some column 
> families, even their data blocks get cached up in the LruBlockCache L1 tier 
> in a multi-tier deploy as happens when doing BucketCache (CombinedBlockCache) 
> setups.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to