[
https://issues.apache.org/jira/browse/HBASE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085846#comment-13085846
]
ramkrishna.s.vasudevan commented on HBASE-4175:
-----------------------------------------------
@Ted,
Actually there were 2 catch blocks with the same content.
I removed the first one that comes in
createTableDescriptor(HTableDescriptor htableDescriptor, Configuration conf,
boolean forceCreation)
but did not remove it from
createTableDescriptor(FileSystem fs, Path rootdir, HTableDescriptor
htableDescriptor, boolean forceCreation)
-> This is because there are scenarios where we can directly use the second api
for createTableDescriptor(In testcases it is getting used directly). So we
need some mechanism to know what exception has come.
If we use the first createTableDescriptor() it is any way calling the second
one so the catch block is not needed.
Is it ok Ted?
> Fix FSUtils.createTableDescriptor()
> -----------------------------------
>
> Key: HBASE-4175
> URL: https://issues.apache.org/jira/browse/HBASE-4175
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Ted Yu
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-4175.patch, HBASE-4175_1.patch
>
>
> Currently createTableDescriptor() doesn't return anything.
> The caller wouldn't know whether the descriptor is created or not. See
> exception handling:
> {code}
> } catch(IOException ioe) {
> LOG.info("IOException while trying to create tableInfo in HDFS", ioe);
> }
> {code}
> We should return a boolean.
> If the table descriptor exists already, maybe we should deserialize from hdfs
> and compare with htableDescriptor argument. If they differ, I am not sure
> what the proper action would be.
> Maybe we can add a boolean argument, force, to createTableDescriptor(). When
> force is true, existing table descriptor would be overwritten.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
