[ https://issues.apache.org/jira/browse/HBASE-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085932#comment-13085932 ]
jirapos...@reviews.apache.org commented on HBASE-4176: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1326/#review1483 ----------------------------------------------------------- Ship it! I'm +1 on commit. Will commit in next day or so unless objection. Let me go work on converting the doc. so can be included in book. Anirudh, answer the below questions if you don't mind. I don't think any necessitate you making new patch. /src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java <https://reviews.apache.org/r/1326/#comment3391> Nice. /src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java <https://reviews.apache.org/r/1326/#comment3392> Should this be abstract? /src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java <https://reviews.apache.org/r/1326/#comment3393> Why define these as ints when you have it below in byte array? Same for 'SKIP'. We'll only work if all is upper-case? Thats OK? Same for AND and OR. I'm ok w/ that long as its called out in doc. /src/main/ruby/shell/commands/scan.rb <https://reviews.apache.org/r/1326/#comment3394> Now I understand what Todd was going on about -- he was suggesting you point at the hbase doc rather than at the issue. That we can fix easy. /src/main/ruby/shell/commands/scan.rb <https://reviews.apache.org/r/1326/#comment3395> What you mean by #2 here? You mean stating filters explicitly rather than via your new string mechanism here? We should swap the order here so it agrees with the example below. - Michael On 2011-08-16 02:42:36, Anirudh Todi wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1326/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-16 02:42:36) bq. bq. bq. Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, and Jonathan Gray. bq. bq. bq. Summary bq. ------- bq. bq. https://issues.apache.org/jira/browse/HBASE-4176: Exposing HBase Filters to the Thrift API bq. bq. Currently, to use any of the filters, one has to explicitly add a scanner for the filter in the Thrift API making it messy and long. bq. With this patch, I am trying to add support for all the filters in a clean way. bq. The user specifies a filter via a string. The string is parsed on the server to construct the filter. More information can be found in the attached document named Filter Language bq. bq. This patch is trying to extend and further the progress made by the patches in HBASE-1744 bq. bq. There is document attached to the HBASE-4176 JIRA that describes this patch in further detail bq. bq. bq. This addresses bug HBASE-4176. bq. https://issues.apache.org/jira/browse/HBASE-4176 bq. bq. bq. Diffs bq. ----- bq. bq. /src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java 1158073 bq. /src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java 1158073 bq. /src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift 1158073 bq. /src/main/ruby/hbase/table.rb 1158073 bq. /src/main/ruby/shell/commands/scan.rb 1158073 bq. /src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java 1158073 bq. bq. Diff: https://reviews.apache.org/r/1326/diff bq. bq. bq. Testing bq. ------- bq. bq. patch includes one test: TestParseFilter.java bq. bq. bq. Thanks, bq. bq. Anirudh bq. bq. > Exposing HBase Filters to the Thrift API > ---------------------------------------- > > Key: HBASE-4176 > URL: https://issues.apache.org/jira/browse/HBASE-4176 > Project: HBase > Issue Type: Improvement > Components: thrift > Reporter: Anirudh Todi > Assignee: Anirudh Todi > Priority: Minor > Attachments: Filter Language(2).docx, Filter Language.docx, > HBASE-4176.patch > > > Currently, to use any of the filters, one has to explicitly add a scanner for > the filter in the Thrift API making it messy and long. With this patch, I am > trying to add support for all the filters in a clean way. The user specifies > a filter via a string. The string is parsed on the server to construct the > filter. More information can be found in the attached document named Filter > Language > This patch is trying to extend and further the progress made by the patches > in the HBASE-1744 JIRA (https://issues.apache.org/jira/browse/HBASE-1744) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira