[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085994#comment-13085994 ]
jirapos...@reviews.apache.org commented on HBASE-4201: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1519/#review1486 ----------------------------------------------------------- Ship it! LGTM - Michael On 2011-08-16 01:49:32, Vlad Dogaru wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1519/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-16 01:49:32) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. This was initially part of the larger patch for HBASE-4192, but it is semantically independent and I split it to a new patch and added a unit test at Todd's suggestion. bq. bq. bq. This addresses bug HBASE-4201. bq. https://issues.apache.org/jira/browse/HBASE-4201 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 7117bce bq. src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 0b21c6c bq. bq. Diff: https://reviews.apache.org/r/1519/diff bq. bq. bq. Testing bq. ------- bq. bq. Ran TestDelayedRpc, added a new test case for this situation. bq. bq. bq. Thanks, bq. bq. Vlad bq. bq. > Fix delayed RPC crash > --------------------- > > Key: HBASE-4201 > URL: https://issues.apache.org/jira/browse/HBASE-4201 > Project: HBase > Issue Type: Bug > Components: ipc > Reporter: Vlad Dogaru > Priority: Minor > > Delayed RPC crashes if return value is not delayed and endDelay is called > before the actual function returns a value. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira