[ 
https://issues.apache.org/jira/browse/HBASE-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048523#comment-14048523
 ] 

Hadoop QA commented on HBASE-11367:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12653304/hbase-11367_v2.patch
  against trunk revision .
  ATTACHMENT ID: 12653304

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 22 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 13 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  public ReplicationPeerZKImpl(Configuration conf, String id, 
ReplicationPeerConfig peerConfig) throws ReplicationException {
+    // TODO: This should be a PB object rather than a String to be parsed!! 
Resolve this in HBASE-11393
+  void addPeer(String peerId, ReplicationPeerConfig peerConfig, String 
tableCFs) throws ReplicationException;
+              new java.lang.String[] { "Clusterkey", 
"ReplicationEndpointImpl", "Data", "Configuration", });
+        // send the edits to the endpoint. Will block until the edits are 
actually sent and acknowledged
+            LOG.warn("Received exception while getting replication peer 
config, skipping replay" + ex);
+      UUID clusterId, ReplicationEndpoint replicationEndpoint, MetricsSource 
metrics) throws IOException {
+    tabCFsMap = ReplicationPeerZKImpl.parseTableCFsFromConfig("tab1 ; ; 
tab2:cf1 ; tab3:cf1,,cf3 ;");
+    tabCFsMap = ReplicationPeerZKImpl.parseTableCFsFromConfig("tab1:tt:cf1 ; 
tab2::cf1 ; tab3:cf1,cf3");

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestCheckTestClasses

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9911//console

This message is automatically generated.

> Pluggable replication endpoint
> ------------------------------
>
>                 Key: HBASE-11367
>                 URL: https://issues.apache.org/jira/browse/HBASE-11367
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.99.0
>
>         Attachments: hbase-11367_v1.patch, hbase-11367_v2.patch
>
>
> We need a pluggable endpoint for replication for more flexibility. See parent 
> jira for more context. 
> ReplicationSource tails the logs for each peer. This jira introduces 
> ReplicationEndpoint which is customizable per peer. ReplicationEndpoint is 
> run in the same RS process and instantiated per replication peer per region 
> server. Implementations of this interface handle the actual shipping of WAL 
> edits to the remote cluster. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to