[ 
https://issues.apache.org/jira/browse/HBASE-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052739#comment-14052739
 ] 

Hadoop QA commented on HBASE-11315:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12654147/hbase-11315-v1.patch
  against trunk revision .
  ATTACHMENT ID: 12654147

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.wal.TestLogRolling

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9973//console

This message is automatically generated.

> Keeping MVCC for configurable longer time 
> ------------------------------------------
>
>                 Key: HBASE-11315
>                 URL: https://issues.apache.org/jira/browse/HBASE-11315
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.99.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: hbase-11315-v1.patch, hbase-11315.patch
>
>
> After hbase-8763, we need keep mvcc number longer in hfile so that it can be 
> used to order changes during writes. For example, the known 
> put,delete,put,... scenario, cross region server scan, out of order puts(in 
> recovery case).
> Current thinking is that we make the retention period configurable(below 
> we're using 1 day to explain). During major compaction, we check hfile's 
> creation time if a hfile creation time is older than 1 day then all mvcc of 
> KVs in that hfile will be removed. If a hfile is created within 1 day, then 
> all mvccs of KVs in that hfile will be kept. 
> In case there are time clock skew, we can firstly sort hfiles based on its 
> seqId in ascending order and find the first hfile's creation time stamp less 
> than 1 day. Then mvcc of all hfiles before the found file will be removed 
> during compaction. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to