[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062781#comment-14062781
]
Hadoop QA commented on HBASE-11064:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655891/HBASE-11064.2.patch
against trunk revision .
ATTACHMENT ID: 12655891
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestCheckTestClasses
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10071//console
This message is automatically generated.
> Odd behaviors of TableName for empty namespace
> ----------------------------------------------
>
> Key: HBASE-11064
> URL: https://issues.apache.org/jira/browse/HBASE-11064
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.3
> Reporter: Hiroshi Ikeda
> Assignee: Rekha Joshi
> Priority: Trivial
> Fix For: 0.99.0, 1.0.0, 0.98.5
>
> Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch,
> HBASE-11064.2.patch
>
>
> In the class TableName,
> {code}
> public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
> ...
> int namespaceDelimIndex = ...
> if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
> isLegalTableQualifierName(tableName);
> } else {
> ...
> {code}
> That means, for example, giving ":a" as the argument throws an exception
> which says invalid qualifier, instead of invalid namespace.
> Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
> with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
