[
https://issues.apache.org/jira/browse/HBASE-11518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064622#comment-14064622
]
stack commented on HBASE-11518:
-------------------------------
Thanks for digging in here [~tianq].
One comment is that you talk up HBASE_CLIENT_INSTANCE_ID only but the
HConnectionKey is made from a set of items:
HConstants.ZOOKEEPER_QUORUM,
HConstants.ZOOKEEPER_ZNODE_PARENT,
HConstants.ZOOKEEPER_CLIENT_PORT,
HConstants.ZOOKEEPER_RECOVERABLE_WAITTIME,
HConstants.HBASE_CLIENT_PAUSE, HConstants.HBASE_CLIENT_RETRIES_NUMBER,
HConstants.HBASE_RPC_TIMEOUT_KEY,
HConstants.HBASE_META_SCANNER_CACHING,
HConstants.HBASE_CLIENT_INSTANCE_ID,
HConstants.RPC_CODEC_CONF_KEY
Should we say something about if your rpc timeout changes or the codec used is
changed, then you'll get a new connection too? Otherwise, I like your change.
And yes, the build boxes have been changed out from under us. We need to make
it so p0 and p1 works again applying git patches. Thanks for referencing the
documentation from the refguide.
[~nkeywal] what you reckon boss?
> doc update for how to create non-shared HConnection
> ---------------------------------------------------
>
> Key: HBASE-11518
> URL: https://issues.apache.org/jira/browse/HBASE-11518
> Project: HBase
> Issue Type: Bug
> Components: documentation
> Affects Versions: 0.96.2, 0.94.21, 0.98.4
> Reporter: Qiang Tian
> Assignee: Qiang Tian
> Priority: Minor
> Attachments: HBASE-11518-master-v1.patch, hbase-11518-master.patch
>
>
> creation for non-shared connections has changed since hbase-3777, but the doc
> still remains the same...
> a simple test program:
> public class testHbase2{
> public static void main(String[] args) throws Exception {
> Configuration conf = HBaseConfiguration.create();
> conf.set("hbase.zookeeper.quorum","localhost");
> conf.set("hbase.zookeeper.property.clientPort", "2181");
> conf.set("hbase.client.instance.id", "2");
> HBaseAdmin admin = new HBaseAdmin(conf);
> conf.set("hbase.client.instance.id", "3");
> HBaseAdmin admin2 = new HBaseAdmin(conf);
> }
> }
> public static HConnection getConnection(final Configuration conf)
> throws IOException {
> HConnectionKey connectionKey = new HConnectionKey(conf);
> LOG.info("###create new connectionkey: " + connectionKey);
> synchronized (CONNECTION_INSTANCES) {
> 14/07/15 18:06:08 INFO client.HConnectionManager: ###create new
> connectionkey: HConnectionKey{properties={hbase.rpc.timeout=600000,
> hbase.client.instance.id=2, hbase.zookeeper.quorum=localhost,
> hbase.client.pause=100, hbase.zookeeper.property.clientPort=2181,
> zookeeper.znode.parent=/hbase, hbase.client.retries.number=35},
> username='tianq'}
> 14/07/15 18:06:08 INFO client.HConnectionManager: ###create new connection###
> 14/07/15 18:06:08 INFO zookeeper.RecoverableZooKeeper: Process
> identifier=hconnection-0x3d7c3d7c connecting to ZooKeeper
> ensemble=localhost:2181
> 14/07/15 18:06:09 INFO client.HConnectionManager: ###create new
> connectionkey: HConnectionKey{properties={hbase.rpc.timeout=600000,
> hbase.client.instance.id=3, hbase.zookeeper.quorum=localhost,
> hbase.client.pause=100, hbase.zookeeper.property.clientPort=2181,
> zookeeper.znode.parent=/hbase, hbase.client.retries.number=35},
> username='tianq'}
> 14/07/15 18:06:09 INFO client.HConnectionManager: ###create new connection###
> 14/07/15 18:06:09 INFO zookeeper.RecoverableZooKeeper: Process
> identifier=hconnection-0xd460d46 connecting to ZooKeeper
> ensemble=localhost:2181
--
This message was sent by Atlassian JIRA
(v6.2#6252)
