[ 
https://issues.apache.org/jira/browse/HBASE-11567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080408#comment-14080408
 ] 

Hadoop QA commented on HBASE-11567:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12658800/HBASE-11567-v1.patch
  against trunk revision .
  ATTACHMENT ID: 12658800

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the trunk's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +   * Generates a marker for the WAL so that we propagate the notion of a 
bulk region load throughout the WAL.
+   * @param familyPaths A list of pairs which maps the name of the column 
family to the location on disk where it is
+   * @param assignSeqId Whether or not to assign a new sequence ID (by way of 
calling flush) or to use the one provided
+                                                                  
List<Pair<byte[], String>> familyPaths,
+              new java.lang.String[] { "TableName", "EncodedRegionName", 
"FamilyPath", "AssignSeqNum", });
+      WALProtos.BulkLoadDescriptor loadDescriptor = 
ProtobufUtil.toBulkLoadDescriptor(this.getRegionInfo().getTable(),
+   * @param sequenceId The current sequenceId in the log at the time when we 
were to write the bulk load marker.
+  public static WALEdit createBulkLoadEvent(HRegionInfo hri, 
WALProtos.BulkLoadDescriptor bulkLoadDescriptor) {
+    testRegionWithFamilies(family1, 
family2).bulkLoadHFiles(withFamilyPathsFor(family1, family2), false);
+  public void 
bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileExistsButNotInTableDescriptor()
 throws IOException {

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestIOFencing
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicas
                  org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
                  org.apache.hadoop.hbase.client.TestReplicasClient
                  org.apache.hadoop.hbase.master.TestRestartCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10237//console

This message is automatically generated.

> Write bulk load events to WAL
> -----------------------------
>
>                 Key: HBASE-11567
>                 URL: https://issues.apache.org/jira/browse/HBASE-11567
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Alex Newman
>         Attachments: HBASE-11567-v1.patch
>
>
> Similar to writing flush (HBASE-11511), compaction(HBASE-2231) to WAL and 
> region open/close (HBASE-11512) , we should persist bulk load events to WAL.
> This is especially important for secondary region replicas, since we can use 
> this information to pick up primary regions' files from secondary replicas.
> A design doc for secondary replica replication can be found at HBASE-11183.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to