[ https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089977#comment-13089977 ]
jirapos...@reviews.apache.org commented on HBASE-4027: ------------------------------------------------------ bq. On 2011-08-19 22:49:55, Todd Lipcon wrote: bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/Cacheable.java, line 55 bq. > <https://reviews.apache.org/r/1214/diff/17/?file=33818#file33818line55> bq. > bq. > does this always return itself? I still think that once something has been serialized, we should throw away the original object, and when we re-instantiate it, it should create a new object. Fixed. Changed the interface. bq. On 2011-08-19 22:49:55, Todd Lipcon wrote: bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1467 bq. > <https://reviews.apache.org/r/1214/diff/17/?file=33821#file33821line1467> bq. > bq. > this object confuses me. once we've serialized something, all we should need is the ByteBuffer. Fixed it. bq. On 2011-08-19 22:49:55, Todd Lipcon wrote: bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1518 bq. > <https://reviews.apache.org/r/1214/diff/17/?file=33821#file33821line1518> bq. > bq. > this isn't right - you need to take into account arrayOffset also. I think this .equals method should move to the tests, or a static method like blocksAndContentsEqual() Fixed. Comparisons are done with if (this.buf.compareTo(castedComparison.buf) != 0) { instead. - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1214/#review1575 ----------------------------------------------------------- On 2011-08-24 02:46:25, Li Pi wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1214/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-24 02:46:25) bq. bq. bq. Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, Jonathan Gray, and Li Pi. bq. bq. bq. Summary bq. ------- bq. bq. Review request - I apparently can't edit tlipcon's earlier posting of my diff, so creating a new one. bq. bq. bq. This addresses bug HBase-4027. bq. https://issues.apache.org/jira/browse/HBase-4027 bq. bq. bq. Diffs bq. ----- bq. bq. conf/hbase-env.sh 2d55d27 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java bfd863e bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/Cacheable.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CacheableDeserializer.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java 3b130d8 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java 097dc50 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java ae75299 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 7ce4f14 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3efba7f bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 7b7bf73 bq. src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java 1ad2ece bq. src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java f0a9832 bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlab.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java d7e43a0 bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 4387170 bq. bq. Diff: https://reviews.apache.org/r/1214/diff bq. bq. bq. Testing bq. ------- bq. bq. Ran benchmarks against it in HBase standalone mode. Wrote test cases for all classes, multithreaded test cases exist for the cache. bq. bq. bq. Thanks, bq. bq. Li bq. bq. > Enable direct byte buffers LruBlockCache > ---------------------------------------- > > Key: HBASE-4027 > URL: https://issues.apache.org/jira/browse/HBASE-4027 > Project: HBase > Issue Type: Improvement > Reporter: Jason Rutherglen > Assignee: Li Pi > Priority: Minor > Attachments: 4027-v5.diff, 4027v7.diff, HBase-4027 (1).pdf, > HBase-4027.pdf, HBase4027v8.diff, HBase4027v9.diff, hbase-4027-v10.5.diff, > hbase-4027-v10.diff, hbase-4027v10.6.diff, hbase-4027v13.1.diff, > hbase-4027v6.diff, hbase4027v11.5.diff, hbase4027v11.6.diff, > hbase4027v11.7.diff, hbase4027v11.diff, hbase4027v12.1.diff, > hbase4027v12.diff, slabcachepatch.diff, slabcachepatchv2.diff, > slabcachepatchv3.1.diff, slabcachepatchv3.2.diff, slabcachepatchv3.diff, > slabcachepatchv4.5.diff, slabcachepatchv4.diff > > > Java offers the creation of direct byte buffers which are allocated outside > of the heap. > They need to be manually free'd, which can be accomplished using an > documented {{clean}} method. > The feature will be optional. After implementing, we can benchmark for > differences in speed and garbage collection observances. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira