[ https://issues.apache.org/jira/browse/HBASE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090495#comment-13090495 ]
Ted Yu commented on HBASE-4241: ------------------------------- Year should be 2011. {code} + * Copyright 2009 The Apache Software Foundation {code} I think a better description: {code} + * Utility scanner that can wrap a collection (anything iterable)and pretend to + * be a KeyValueScanner. {code} would be: {code} + * Utility scanner that wraps a collection (anything iterable) and serves + * as a KeyValueScanner. {code} Please run through unit tests. If they pass, please use reviewboard for further comments. Good work. > Optimize flushing of the Store cache for max versions and (new) min versions > ---------------------------------------------------------------------------- > > Key: HBASE-4241 > URL: https://issues.apache.org/jira/browse/HBASE-4241 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.92.0 > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Attachments: 4241-v2.txt, 4241.txt > > > As discussed with with Jon, there is room for improvement in how the memstore > is flushed to disk. > Currently only expired KVs are pruned before flushing, but we can also prune > versions if we find at least maxVersions versions in the memstore. > The same holds for the new minversion feature: If we find at least minVersion > versions in the store we can remove all further versions that are expired. > Generally we should use the same mechanism here that is used for Compaction. > I.e. StoreScanner. We only need to add a scanner to Memstore that can scan > along the current snapshot. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira