[
https://issues.apache.org/jira/browse/HBASE-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101043#comment-14101043
]
stack commented on HBASE-11610:
-------------------------------
This patch is a bit of a hack. We are doing a one-off inside RegionStateStore
to put up multiple HConnection instances (for sure we are creating many
distinct instances?). I'd doubt anyone but you fellas will know of its
existance (Needs a release not on the new config,
"hbase.statestore.meta.connection", and new config should probably be called
"hbase.regionstatestore.meta.connection"). Would be nice if this connection
setup was off in a separate class so should anyone else want to do this trick,
they'll not duplicate your effort. This is just a nit though. I'm also fine
with adding in stuff that is custom for you fellas (custom for now) just as
long as it is well doc'd.
When would this code trigger?
+ if (hConnectionPool == null) {
+ hConnectionPool = new
HConnection[]{HConnectionManager.createConnection(server.getConfiguration())};
+ }
i.e. when would hConnectionPool be null?
Should this be private? + private ThreadLocal<HTableInterface>
threadLocalHTable =
It should have a comment on when this thread local gets instantiated -- what
the current thread is at the time.
> Enhance remote meta updates
> ---------------------------
>
> Key: HBASE-11610
> URL: https://issues.apache.org/jira/browse/HBASE-11610
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jimmy Xiang
> Assignee: Virag Kothari
> Attachments: HBASE-11610.patch
>
>
> Currently, if the meta region is on a regionserver instead of the master,
> meta update is synchronized on one HTable instance. We should be able to do
> better.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
