[
https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103389#comment-14103389
]
Alex Newman commented on HBASE-4955:
------------------------------------
Agreed about the third level for tests. I would like someone to review this
patch. I understand if you want the formatting changes in a separate patch. I
am not sure what the protocol for that should be. I am also trying to spawn
another build on the apache build server, to see if it is reliably red. I can
tell you, the tests run blue on our jenkins for the first time, in a while.
IMHO, we should either use threadcount or forkcount. Not both. Thus the
specification for a forkmode should also be unneeded. From
http://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
"The important thing to remember with the parallel option is: the concurrency
happens within the same JVM process. That is efficient in terms of memory and
execution time, but you may be more vulnerable towards race conditions or other
unexpected and hard to reproduce behavior."
"The other possibility for parallel test execution" [other than thread
parallelism] "is setting the parameter forkCount to a value higher than 1. The
next section covers the details about this and the related reuseForks
property."
For now, lets learn to walk before we run and use the more reliable test
mechanism generally. In addition, it has the advantage of
maven.test.redirectTestOutputToFile working. Which I couldn't get working with
the new version of surefire and the old parallel options.This may be related to
https://jira.codehaus.org/browse/SUREFIRE-800.
> Use the official versions of surefire & junit
> ---------------------------------------------
>
> Key: HBASE-4955
> URL: https://issues.apache.org/jira/browse/HBASE-4955
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0, 0.98.0, 0.96.0, 0.99.0
> Environment: all
> Reporter: Nicolas Liochon
> Assignee: Alex Newman
> Priority: Critical
> Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch,
> 4955.v2.patch, 4955.v2.patch, 4955.v3.patch, 4955.v3.patch, 4955.v3.patch,
> 4955.v4.patch, 4955.v4.patch, 4955.v4.patch, 4955.v4.patch, 4955.v4.patch,
> 4955.v4.patch, 4955.v5.patch, 4955.v6.patch, 4955.v7.patch, 4955.v7.patch,
> 4955.v8.patch, 4955.v9.patch, 8204.v4.patch, HBASE-4955-v10.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all
> what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no
> feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the
> trunk
> 786 (@Category with forkMode=always): fixed, we use the official
> implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official
> implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on
> our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed
> in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in
> our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk,
> not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk,
> fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are
> fixed in our version but not on trunk.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
