[ 
https://issues.apache.org/jira/browse/HBASE-11800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106163#comment-14106163
 ] 

Jonathan Hsieh commented on HBASE-11800:
----------------------------------------

changes to HTableInterface seem fine.

Though Batch and CoprocessorRpcChannel and its methods won't be private, the 
class level still should get some explicit annotation:

@interfaceAudience.Public
@interfaceStability.Evolving  (or Stable depending on how you feel about it).

+1 once those are added.

> Coprocessor service methods in HTableInterface should be annotated public
> -------------------------------------------------------------------------
>
>                 Key: HBASE-11800
>                 URL: https://issues.apache.org/jira/browse/HBASE-11800
>             Project: HBase
>          Issue Type: Task
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>         Attachments: HBASE-11800.patch
>
>
> The {{HTableInterface.coprocessorService(...)}} and 
> {{HTableInterface.batchCoprocessorService(...)}} methods were made private in 
> HBASE-9529, when the coprocessor APIs were seen as unstable and evolving.
> However, these methods represent a standard way for clients to use custom 
> APIs exposed via coprocessors.  In that sense, they are targeted at general 
> HBase users (who may run but not develop coprocessors), as opposed to 
> coprocessor developers who want to extend HBase.
> The coprocessor endpoint API has also remained much more stable than the 
> coprocessor Observer interfaces, which tend to change along with HBase 
> internals.  So there should not be much difficulty in supporting these 
> methods as part of the public API.
> I think we should drop the {{@InterfaceAudience.Private}} annotation on these 
> methods and support them as part of the public {{HTableInterface}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to