[ 
https://issues.apache.org/jira/browse/HBASE-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111734#comment-14111734
 ] 

Hadoop QA commented on HBASE-11788:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12664460/HBASE-11788-master.patch
  against trunk revision .
  ATTACHMENT ID: 12664460

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +              put.add(new KeyValue(proto.getRow().toByteArray(), family, 
qual, ts, fromDeleteType(qv.getDeleteType()), null, tags));
+              put.add(new KeyValue(proto.getRow().toByteArray(), family, qual, 
ts, fromDeleteType(qv.getDeleteType())));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s):       
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testSplitDaughtersNotInMeta(TestHBaseFsck.java:1621)
        at 
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.testMultithreadedTableMapper(TestMultithreadedTableMapper.java:125)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10600//console

This message is automatically generated.

> hbase is not deleting the cell when a Put with a KeyValue, 
> KeyValue.Type.Delete is submitted
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11788
>                 URL: https://issues.apache.org/jira/browse/HBASE-11788
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0, 0.96.1.1, 0.98.5, 2.0.0
>         Environment: Cloudera CDH 5.1.x
>            Reporter: Cristian Armaselu
>            Assignee: Srikanth Srungarapu
>         Attachments: HBASE-11788-master.patch, TestPutWithDelete.java
>
>
> Code executed:
> {code}
>     @Test
>     public void testHbasePutDeleteCell() throws Exception {
>         TableName tableName = TableName.valueOf("my_test");
>         Configuration configuration = HBaseConfiguration.create();
>         HTableInterface table = new HTable(configuration, tableName);
>         final String rowKey = "12345";
>         final byte[] familly = Bytes.toBytes("default");
>         // put one row
>         Put put = new Put(Bytes.toBytes(rowKey));
>         put.add(familly, Bytes.toBytes("A"), Bytes.toBytes("a"));
>         put.add(familly, Bytes.toBytes("B"), Bytes.toBytes("b"));
>         put.add(familly, Bytes.toBytes("C"), Bytes.toBytes("c"));
>         table.put(put);
>         // get row back and assert the values
>         Get get = new Get(Bytes.toBytes(rowKey));
>         Result result = table.get(get);
>         Assert.isTrue(Bytes.toString(result.getValue(familly, 
> Bytes.toBytes("A"))).equals("a"), "Column A value should be a");
>         Assert.isTrue(Bytes.toString(result.getValue(familly, 
> Bytes.toBytes("B"))).equals("b"), "Column B value should be b");
>         Assert.isTrue(Bytes.toString(result.getValue(familly, 
> Bytes.toBytes("C"))).equals("c"), "Column C value should be c");
>         // put the same row again with C column deleted
>         put = new Put(Bytes.toBytes(rowKey));
>         put.add(familly, Bytes.toBytes("A"), Bytes.toBytes("a"));
>         put.add(familly, Bytes.toBytes("B"), Bytes.toBytes("b"));
>         put.add(new KeyValue(Bytes.toBytes(rowKey), familly, 
> Bytes.toBytes("C"), HConstants.LATEST_TIMESTAMP, KeyValue.Type.DeleteColumn));
>         table.put(put);
>         // get row back and assert the values
>         get = new Get(Bytes.toBytes(rowKey));
>         result = table.get(get);
>         Assert.isTrue(Bytes.toString(result.getValue(familly, 
> Bytes.toBytes("A"))).equals("a"), "Column A value should be a");
>         Assert.isTrue(Bytes.toString(result.getValue(familly, 
> Bytes.toBytes("B"))).equals("b"), "Column A value should be b");
>         Assert.isTrue(result.getValue(familly, Bytes.toBytes("C")) == null, 
> "Column C should not exists");
>     }
> {code}
> This assertion fails, the cell is not deleted but rather the value is empty:
> {code}
> hbase(main):029:0> scan 'my_test'
> ROW                                                   COLUMN+CELL             
>                                                                               
>                                                       
>  12345                                                column=default:A, 
> timestamp=1408473082290, value=a                                              
>                                                             
>  12345                                                column=default:B, 
> timestamp=1408473082290, value=b                                              
>                                                             
>  12345                                                column=default:C, 
> timestamp=1408473082290, value=      
> {code}
> This behavior is different than previous 4.8.x Cloudera version and is 
> currently corrupting all hive queries involving is null or is not null 
> operators on the columns mapped to hbase



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to