[ https://issues.apache.org/jira/browse/HBASE-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114951#comment-14114951 ]
Hadoop QA commented on HBASE-11726: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665263/HBASE-11726.v1.diff against trunk revision . ATTACHMENT ID: 12665263 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRollingRestart org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10635//console This message is automatically generated. > Master should fail-safe if starting with a pre 0.96 layout > ---------------------------------------------------------- > > Key: HBASE-11726 > URL: https://issues.apache.org/jira/browse/HBASE-11726 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.96.2, 0.99.0, 0.98.5, 2.0.0 > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Priority: Critical > Attachments: HBASE-11726.v0.diff, HBASE-11726.v1.diff > > > We recently saw this: If user inadvertently starts the HBase Master after > deploying new HBase binaries (any version that supports namespaces), the > HMaster will start the migration to PBs the the {{hbase.version}} file per > HBASE-5453 and that will write a new version file PB-serialized but with the > old version number. Further restarts of the master will fail because the > hbase version file has been migrated to PBs and there will be version > mismatch. The right approach should be to fail safe the master if we find an > old {{hbase.version}} file in order to force user to run upgrade tool. -- This message was sent by Atlassian JIRA (v6.2#6252)