[
https://issues.apache.org/jira/browse/HBASE-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117055#comment-14117055
]
ramkrishna.s.vasudevan commented on HBASE-11777:
------------------------------------------------
bq. But see the call to KeyValueUtil.ensureKeyValue which will recreate KV and
copy both key and value parts!!!
bq. I can correct this by BufferedDataBlockEncoder.ClonedSeekerState
implementing SettableSequenceId and now we wont be having
KeyValueUtil.ensureKeyValue.
Yes, that is why ClonedSeekerState was added to avoid copying of value. Infact
the setSequenceId introduced in HBASE-11591 was aware that we were copying both
values and key part and that is why raised this JIRA to solve it.
Ideally this setSequenceId change is only needed for ClonedSeekerState only.
Because in all other non DBE cases it will be only KV any way and so
ensureKeyValue would not copy anything (i mean before we go about offheap type
of cells). So this change is mainly for DBE cases only.
> Find a way to set sequenceId on Cells on the server
> ---------------------------------------------------
>
> Key: HBASE-11777
> URL: https://issues.apache.org/jira/browse/HBASE-11777
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.99.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0, 2.0.0, 0.98.7
>
> Attachments: CellWithSequenceNumber.java, HBASE-11777.patch,
> HBASE-11777_V2.patch, HBASE-11777_V3.patch, HBASE-11777_V4.patch
>
>
> Over in HBASE-11591 there was a need to set the sequenceId of the HFile to
> the bulk loaded KVs. Since we are trying to use the concept of Cells in the
> read path if we need to use setSequenceId(), then the Cell has to be
> converted to KV and only KeyValue impl has the accessor setSequenceId().
> [~anoop.hbase] suggested if we can use a Server side impl of Cell and have
> these accessors in them.
> This JIRA aims to solve this and see the related code changes that needs to
> be carried out for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
