[ https://issues.apache.org/jira/browse/HBASE-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-11984: -------------------------- Attachment: 11984v2.txt The idea is that for the three tests that look for class files in dirs, we now create the classes for it to find rather than expect them to be present under target dir. The changes are kinda ugly because the class naming and package naming in this test class is a little cryptic (I'm sure it made 'sense' at one time). I tried not disturb it too much. Made stuff local to the test... i.e. named classes for method name and added package suffixes for the package name too. Going to just commit. Its test fixup. Will leave issue open in case we see other failures out of here. > TestClassFinder failing on occasion > ----------------------------------- > > Key: HBASE-11984 > URL: https://issues.apache.org/jira/browse/HBASE-11984 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: 0001-More-debug.patch, 11984v2.txt > > > Failed like this: > {code} > Tests run: 11, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 1.913 sec > <<< FAILURE! - in org.apache.hadoop.hbase.TestClassFinder > testClassFinderFiltersByClassInDirs(org.apache.hadoop.hbase.TestClassFinder) > Time elapsed: 0.028 sec <<< FAILURE! > java.lang.AssertionError: expected:<-1> but was:<0> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.hadoop.hbase.TestClassFinder.testClassFinderFiltersByClassInDirs(TestClassFinder.java:259) > testClassFinderCanFindClassesInDirs(org.apache.hadoop.hbase.TestClassFinder) > Time elapsed: 0.017 sec <<< FAILURE! > java.lang.AssertionError: null > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:223) > testClassFinderFiltersByNameInDirs(org.apache.hadoop.hbase.TestClassFinder) > Time elapsed: 0.018 sec <<< FAILURE! > java.lang.AssertionError: expected:<-1> but was:<0> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.hadoop.hbase.TestClassFinder.testClassFinderFiltersByNameInDirs(TestClassFinder.java:242) > {code} > ... in precommit > https://builds.apache.org/job/PreCommit-HBASE-Build/10912/console -- This message was sent by Atlassian JIRA (v6.3.4#6332)