[
https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095099#comment-13095099
]
Ted Yu commented on HBASE-4310:
-------------------------------
Minor comment:
{code}
+ + StringUtils.humanReadableInt(this.heapSize()) + " bytes." + ", "
+ + "churnTime=" + this.timeSinceLastAccess.get());
{code}
churnTime should have unit. Since the value would be big in nanoseconds, there
should be some normalization.
Otherwise, patch looks good.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt,
> metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs
> metrics of size 0 to save space. Also added second log for those things that
> are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
