[
https://issues.apache.org/jira/browse/HBASE-12019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152474#comment-14152474
]
Lars Hofhansl commented on HBASE-12019:
---------------------------------------
Looking at the patch now... It does not make much sense anyway:
{code}
+if [ -z "${HBASE_ROOT_LOGGER}" ]; then
export HBASE_ROOT_LOGGER=${HBASE_ROOT_LOGGER:-"INFO,RFA"}
+fi
{code}
The existing code (at least in 0.98+) {{export
HBASE_ROOT_LOGGER=$\{HBASE_ROOT_LOGGER:\-"INFO,RFA"}}} seems to do the right
thing already anyway - notice the {{$\{HBASE_ROOT_LOGGER:-}} part, which
evaluates to 2nd part only if the variable is null.
In any case, going to commit the addendum to 0.94 now.
> hbase-daemon.sh overwrite HBASE_ROOT_LOGGER and HBASE_SECURITY_LOGGER
> variables
> -------------------------------------------------------------------------------
>
> Key: HBASE-12019
> URL: https://issues.apache.org/jira/browse/HBASE-12019
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.99.0, 0.94.23, 0.98.6
> Environment: Linux
> Reporter: Sebastien Barrier
> Assignee: Sebastien Barrier
> Priority: Minor
> Labels: patch
> Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>
> Attachments: 12019-0.94-addendum.txt, HBASE-12019.patch
>
>
> hbase-env.sh is supposed to be used to set environment variables like
> HBASE_ROOT_LOGGER and HBASE_SECURITY_LOGGER but hbase-daemon.sh overwrite the
> export of thoses, the benefit of hbase-env.sh is lost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
