[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154563#comment-14154563 ]
Anoop Sam John edited comment on HBASE-12112 at 10/1/14 8:33 AM: ----------------------------------------------------------------- TestAsyncProcess passing locally 1 javadoc warn is related to this patch which I will fix on commit. The findbugs warns seems not related Will commit to 0.99+ was (Author: anoop.hbase): TestAsyncProcess passing locally 1 javadoc warn is related to this patch which I will commit on fix. The findbugs warns seems not related Will commit to 0.99+ > Avoid KeyValueUtil#ensureKeyValue some more simple cases > -------------------------------------------------------- > > Key: HBASE-12112 > URL: https://issues.apache.org/jira/browse/HBASE-12112 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0, 0.99.1 > > Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, > HBASE-12112_V2.patch, HBASE-12112_V4.patch, HBASE-12112_V4.patch > > > This include fixes with > - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) > - Printing the key portion of a cell (rk+cf+q+ts+type). These are in > Exception messages > - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to > cell#getxxx() which involves bytes copying. This is not a hot area still we > can avoid as much usage of deprecated methods as possible in core code. I > believe these bytes copying methods are used in many other parts and later we > can try fixing those as per area importance > - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)