[ 
https://issues.apache.org/jira/browse/HBASE-12095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155056#comment-14155056
 ] 

Hudson commented on HBASE-12095:
--------------------------------

FAILURE: Integrated in HBase-0.98 #554 (See 
[https://builds.apache.org/job/HBase-0.98/554/])
HBASE-12095 SecureWALCellCodec should handle the case where encryption is 
disabled (tedyu: rev e78224bd66a0adbd08e6eea9a3dd494d17f861c3)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogReaderOnSecureHLog.java


> SecureWALCellCodec should handle the case where encryption is disabled
> ----------------------------------------------------------------------
>
>                 Key: HBASE-12095
>                 URL: https://issues.apache.org/jira/browse/HBASE-12095
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6
>            Reporter: Ashish Singhi
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 0.98.7, 0.99.1
>
>         Attachments: 12095-v1.txt, 12095-v1.txt, 12095-v2.txt
>
>
> I observed that when I have the following value set in my hbase-site.xml file
> {code}
> <property>
> <name>hbase.regionserver.wal.encryption</name>
> <value>false</value>
> </property>
> <property>
> <name>hbase.regionserver.hlog.reader.impl</name>
> <value>org.apache.hadoop.hbase.regionserver.wal.SecureProtobufLogReader</value>
> </property>
> <property>
> <name>hbase.regionserver.hlog.writer.impl</name>
> <value>org.apache.hadoop.hbase.regionserver.wal.SecureProtobufLogWriter</value>
> </property>
> {code}
> And while log splitting on hbase service restart, master shutdown with 
> following exception.
> Exception in master log
> {code}
> 2014-09-24 17:14:28,590 FATAL [master:host-10-18-40-18:60000] master.HMaster: 
> Master server abort: loaded coprocessors are: 
> [org.apache.hadoop.hbase.security.access.AccessController]
> 2014-09-24 17:14:28,590 FATAL [master:host-10-18-40-18:60000] master.HMaster: 
> Unhandled exception. Starting shutdown.
> java.io.IOException: error or interrupted while splitting logs in 
> [hdfs://10.18.40.18:8020/tmp/hbase-ashish/hbase/WALs/host-10-18-40-18,60020,1411558717849-splitting]
>  Task = installed = 6 done = 0 error = 6
>                 at 
> org.apache.hadoop.hbase.master.SplitLogManager.splitLogDistributed(SplitLogManager.java:378)
>                 at 
> org.apache.hadoop.hbase.master.MasterFileSystem.splitLog(MasterFileSystem.java:415)
>                 at 
> org.apache.hadoop.hbase.master.MasterFileSystem.splitMetaLog(MasterFileSystem.java:307)
>                 at 
> org.apache.hadoop.hbase.master.MasterFileSystem.splitMetaLog(MasterFileSystem.java:298)
>                 at 
> org.apache.hadoop.hbase.master.HMaster.splitMetaLogBeforeAssignment(HMaster.java:1071)
>                 at 
> org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:863)
>                 at 
> org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:612)
>                 at java.lang.Thread.run(Thread.java:745)
> Exception in region server log
> 2014-09-24 20:10:16,535 WARN  [RS_LOG_REPLAY_OPS-host-10-18-40-18:60020-1] 
> regionserver.SplitLogWorker: log splitting of 
> WALs/host-10-18-40-18,60020,1411558717849-splitting/host-10-18-40-18%2C60020%2C1411558717849.1411558724316.meta
>  failed, returning error
> java.io.IOException: Cannot get log reader
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogFactory.createReader(HLogFactory.java:161)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogFactory.createReader(HLogFactory.java:89)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.getReader(HLogSplitter.java:660)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.getReader(HLogSplitter.java:569)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:282)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:225)
>                 at 
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:143)
>                 at 
> org.apache.hadoop.hbase.regionserver.handler.HLogSplitterHandler.process(HLogSplitterHandler.java:82)
>                 at 
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:128)
>                 at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>                 at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>                 at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.UnsupportedOperationException: Unable to find suitable 
> constructor for class 
> org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec
>                 at 
> org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:39)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.WALCellCodec.create(WALCellCodec.java:101)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.getCodec(ProtobufLogReader.java:242)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initAfterCompression(ProtobufLogReader.java:247)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.SecureProtobufLogReader.initAfterCompression(SecureProtobufLogReader.java:138)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:85)
>                 at 
> org.apache.hadoop.hbase.regionserver.wal.HLogFactory.createReader(HLogFactory.java:113)
>                 ... 11 more
> Caused by: java.lang.NoSuchMethodException: 
> org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec.<init>(org.apache.hadoop.conf.Configuration,
>  org.apache.hadoop.hbase.regionserver.wal.CompressionContext)
>                 at java.lang.Class.getConstructor0(Class.java:2849)
>                 at java.lang.Class.getDeclaredConstructor(Class.java:2053)
>                 at 
> org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:33)
>                 ... 17 more
> {code}
> Question,
> When wal encryption is disabled should we set SecureWALCellCodec for 
> cellCodecClsName in WALHeader.Builder object  ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to