[ 
https://issues.apache.org/jira/browse/HBASE-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161087#comment-14161087
 ] 

stack commented on HBASE-12029:
-------------------------------

TestRegionReplicaReplicationEndpoint has been disabled for now as flakey.

bq. Were Connections automatically closed in Map/Reduces using the pooled 
approach? If so, how should the Connections be closed in the new approach of 
user managed Connections? 

They were.  We were refcounting and when all closes were done, we'd shutdown 
the Connection.

On 

... 105       // TODO: Close the Connection somewhere.

doesn't InputFormat have a close on it in the Interface?  Could we close 
created connections and admins in there?

Apart from this, patch looks good.







> Use Table and RegionLocator in HTable.getRegionLocations() 
> -----------------------------------------------------------
>
>                 Key: HBASE-12029
>                 URL: https://issues.apache.org/jira/browse/HBASE-12029
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.99.1
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>         Attachments: HBASE-12029.patch, HBASE-12029_v1.patch, 
> HBASE-12029_v2.patch, HBASE-12029_v3.patch, HBASE-12029_v4.patch, 
> HBASE-12029_v4.patch, HBASE-12029_v5.patch, HBASE-12029_v6.patch, 
> HBASE-12029_v7.patch
>
>
> HTable.getRegionLocations() is an internal deprecated API.  There are plenty 
> of internal uses of the method, and it would be ideal to use the Table and 
> RegionLocator interfaces instead of the HTable method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to